This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
envoy/route: Delete log line providing little info #2374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
snehachhabria
approved these changes
Jan 25, 2021
ksubrmnn
approved these changes
Jan 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this line to provide little to no value - decided to remove it.
Should we ever need to log the activity of this function we may consider augmenting the log line with additional context to know a bit more about what is being updated.
Signed-off-by: Delyan Raychev delyan.raychev@microsoft.com
Please answer the following questions with yes/no.