This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
ref(pkg/envoy/eds/*): Remove redundant code from EDS and update test #2524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR removes the dependency on services from EDS and updates the tests. Further it converts the tes from ginkgo to use go testing framework Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
eduser25
approved these changes
Feb 12, 2021
shashankram
approved these changes
Feb 12, 2021
| }) | ||
| }) | ||
| actual, err := NewResponse(meshCatalog, proxy, nil, mockConfigurator, nil) | ||
| assert.Empty(err) |
There was a problem hiding this comment.
Suggested change
| assert.Empty(err) | |
| assert.Nil(err) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR removes the dependency on services from EDS and updates the tests. Further it converts the test from ginkgo to use go testing framework
Signed-off-by: Sneha Chhabria snchh@microsoft.com
Part of #1658
Affected area:
Please answer the following questions with yes/no.
no