This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
feat(metrics): Add "unknown" for dest labels on local replies #2587
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Because
destination_*
tags are generated at the request's destination,requests that invoke a local response from Envoy have no
destination_*
values. This change modifies Envoy to add the expected header keys with
the value "unknown" to stay consistent with the behavior for requests
that don't invoke a local reply.
This PR is part of several which together extend Envoy to generate custom
metrics needed to implement the SMI metrics spec (#984).
Here is a map of the PRs as they're currently planned:
ref(injector): pass pod object to getEnvoySidecarContainerSpecfeat(metrics): add WASM metrics sourcedocs(metrics): Add docs for WASM statsfeat(metrics): Add WASM feature flagfeat(metrics): Add stats.wasm to proxy configfeat(injector): Add name, workload name, workload kind to PodMetadatafeat(metrics): Add source labels to WASM metricsfeat(metrics): Add dest labels to WASM metricsThe remaining changes can be found here: main...nojnhuh:wasm-metrics
Affected area:
Please answer the following questions with yes/no.
No