This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
sds: Remove unused services list from SDS struct #2633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
snehachhabria
approved these changes
Feb 26, 2021
Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
draychev
force-pushed
the
small-refactor-to-sds-tests-remove-services
branch
from
33a2abc to
1d3c76a
Compare
shashankram
approved these changes
Feb 26, 2021
eduser25
approved these changes
Feb 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up SDS:
proxyServicesfrom thesdsImplstructGetServicesFromEnvoyCertificate(), which is no longer needed.