Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

docs(install): Document how to install on OpenShift #2784

Merged
merged 6 commits into from
Mar 10, 2021

Conversation

ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Mar 9, 2021

Signed-off-by: Kalya Subramanian kasubra@microsoft.com

Description:
Document how to install OSM on OpenShift

Fixes #2785

Affected area:

  • New Functionality [ ]
  • Documentation [X]
  • Install [ ]
  • Control Plane [ ]
  • CLI Tool [ ]
  • Certificate Management [ ]
  • Networking [ ]
  • Metrics [ ]
  • SMI Policy [ ]
  • Security [ ]
  • Tests [ ]
  • CI System [ ]
  • Performance [ ]
  • Other [ ]

Please answer the following questions with yes/no.

  • Does this change contain code from or inspired by another project? If so, did you notify the maintainers and provide attribution?
    No

Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
@ksubrmnn ksubrmnn requested a review from a team as a code owner March 9, 2021 22:18
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
demo/README.md Outdated
Comment on lines 42 to 45
To run the demo on OpenShift, you must enable privileged init containers.
```shell
./demo/run-osm-demo.sh --set="OpenServiceMesh.enablePrivilegedInitContainer=true"
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add this automatically in the demo script based on DEPLOY_ON_OPENSHIFT? I suppose making users add this serves as a good disclaimer though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I considered that early on but it didn't seem compatible if users also passed in additional arguments.

For example, this doesn't work:

bin/osm install --set="OpenServiceMesh.enablePrivilegedInitContainer=true" --set="OpenServiceMesh.envoyLogLevel=info"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, using --set multiple times should work. In this case, --set="OpenServiceMesh.envoyLogLevel=info" doesn't work because the --envoy-log-level flag exists.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring that out! Seems like a bug to me so I filed #2806

The latest commit enables privileged init container when DEPLOY_ON_OPENSHIFT is set to true.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the script is setting this value automatically, should we remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

docs/content/docs/install/manual_demo/_index.md Outdated Show resolved Hide resolved
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
@ksubrmnn ksubrmnn merged commit f783b19 into openservicemesh:main Mar 10, 2021
@ksubrmnn ksubrmnn deleted the openshift branch March 10, 2021 22:45
@michelleN michelleN added this to the v0.8.0-rc.2 milestone Mar 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to install OSM on OpenShift
4 participants