-
Notifications
You must be signed in to change notification settings - Fork 277
docs(install): Document how to install on OpenShift #2784
Conversation
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
demo/README.md
Outdated
To run the demo on OpenShift, you must enable privileged init containers. | ||
```shell | ||
./demo/run-osm-demo.sh --set="OpenServiceMesh.enablePrivilegedInitContainer=true" | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we add this automatically in the demo script based on DEPLOY_ON_OPENSHIFT
? I suppose making users add this serves as a good disclaimer though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I considered that early on but it didn't seem compatible if users also passed in additional arguments.
For example, this doesn't work:
bin/osm install --set="OpenServiceMesh.enablePrivilegedInitContainer=true" --set="OpenServiceMesh.envoyLogLevel=info"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, using --set
multiple times should work. In this case, --set="OpenServiceMesh.envoyLogLevel=info"
doesn't work because the --envoy-log-level
flag exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for figuring that out! Seems like a bug to me so I filed #2806
The latest commit enables privileged init container when DEPLOY_ON_OPENSHIFT is set to true.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the script is setting this value automatically, should we remove this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Signed-off-by: Kalya Subramanian kasubra@microsoft.com
Description:
Document how to install OSM on OpenShift
Fixes #2785
Affected area:
Please answer the following questions with yes/no.
No