This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
catalog: Remove GetServicesForServiceAccount from MeshCataloger interface #3115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draychev
added
the
do-not-merge/hold
12 tasks
draychev
changed the title
draychev
force-pushed
the
catalog_tweaks_5
branch
from
9b1fb92 to
f717f6d
Compare
…face Signed-off-by: Delyan Raychev <delyan.raychev@microsoft.com>
draychev
force-pushed
the
catalog_tweaks_5
branch
from
f717f6d to
702ff6a
Compare
shashankram
approved these changes
Apr 13, 2021
eduser25
approved these changes
Apr 13, 2021
nojnhuh
approved these changes
Apr 13, 2021
draychev
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the MeshCataloger interface by removing GetServicesForServiceAccount from it.
I see that we are not using
GetServicesForServiceAccount()anywhere outside ofpkg/catalog. It seems unnecessary to have this exposed via Interface to the rest of the world. I propose we privatize GetServicesForServiceAccount and remove it fromMeshCatalogerinterface.