Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

test(e2e): Enable priv init container for OpenShift #3480

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

ksubrmnn
Copy link
Contributor

@ksubrmnn ksubrmnn commented Jun 1, 2021

Signed-off-by: Kalya Subramanian kasubra@microsoft.com

Description:
Partially fixes #3097

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [X]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?
    • Did you notify the maintainers and provide attribution?
      No
  2. Is this a breaking change?
    No

Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
@ksubrmnn ksubrmnn requested a review from a team as a code owner June 1, 2021 18:49
@codecov-commenter
Copy link

codecov-commenter commented Jun 1, 2021

Codecov Report

Merging #3480 (32df6ce) into main (d858adb) will decrease coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3480      +/-   ##
==========================================
- Coverage   65.87%   65.70%   -0.18%     
==========================================
  Files         169      169              
  Lines        7886     7910      +24     
==========================================
+ Hits         5195     5197       +2     
- Misses       2660     2682      +22     
  Partials       31       31              
Flag Coverage Δ
unittests 65.70% <ø> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/catalog/catalog.go 92.85% <0.00%> (-7.15%) ⬇️
pkg/catalog/mock_catalog_generated.go 0.00% <0.00%> (ø)
pkg/kubernetes/announcement_handlers.go 77.14% <0.00%> (+5.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4aa177a...32df6ce. Read the comment docs.

@ksubrmnn ksubrmnn merged commit ed30fa8 into openservicemesh:main Jun 1, 2021
@ksubrmnn ksubrmnn deleted the oc_e2e branch June 1, 2021 20:27
timmyreilly pushed a commit to timmyreilly/osm that referenced this pull request Jun 3, 2021
…3480)

Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
ksubrmnn added a commit to ksubrmnn/osm that referenced this pull request Jul 6, 2021
…3480)

Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
ksubrmnn added a commit that referenced this pull request Jul 6, 2021
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure e2es to run on OpenShift
4 participants