This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
tests(e2e): Create ServiceAccount for Vault #3571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## main #3571 +/- ##
==========================================
+ Coverage 66.12% 66.13% +0.01%
==========================================
Files 174 174
Lines 8309 8309
==========================================
+ Hits 5494 5495 +1
+ Misses 2784 2783 -1
Partials 31 31
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
snehachhabria
approved these changes
Jun 10, 2021
nojnhuh
approved these changes
Jun 10, 2021
whitneygriffith
pushed a commit
to whitneygriffith/osm
that referenced
this pull request
Jun 15, 2021
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com> Signed-off-by: Whitney Griffith <whitney.griffith16@gmail.com>
whitneygriffith
pushed a commit
to whitneygriffith/osm
that referenced
this pull request
Jun 16, 2021
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
whitneygriffith
pushed a commit
to whitneygriffith/osm
that referenced
this pull request
Jun 17, 2021
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
shalier
pushed a commit
to shalier/osm
that referenced
this pull request
Jun 30, 2021
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com>
|
@Mergifyio backport release-v0.9 |
mergify bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
Signed-off-by: Kalya Subramanian <kasubra@microsoft.com> (cherry picked from commit c298f7b)
|
Command
|
nshankar13
added a commit
that referenced
this pull request
Jul 27, 2021
…/pr-3571 tests(e2e): Create ServiceAccount for Vault (backport #3571)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kalya Subramanian kasubra@microsoft.com
Description:
Adds a ServiceAccount for when vault is deployed in e2es. This allows the vault to be deployed with the privileged SCC on OpenShift which is necessary since it requires the IPC_LOCK capability.
The OpenShift docs recommend the privileged SCC here: https://www.openshift.com/blog/integrating-vault-with-legacy-applications
Related to #3097
Affected area:
Please answer the following questions with yes/no.
No
No