Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

catalog/traffic-policies: add error codes #3717

Merged
merged 1 commit into from
Jul 1, 2021

Conversation

shashankram
Copy link
Member

Description:
Adds error codes for inbound and outbound
traffic policy related errors.

Also makes the logging of resource names consistent.

Part of #2866

Signed-off-by: Shashank Ram shashr2204@gmail.com

Affected area:

Functional Area
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

Adds error codes for inbound and outbound
traffic policy related errors.

Part of openservicemesh#2866

Signed-off-by: Shashank Ram <shashr2204@gmail.com>
@shashankram shashankram requested a review from a team as a code owner July 1, 2021 20:45
@codecov-commenter
Copy link

Codecov Report

Merging #3717 (4af79f1) into main (0322387) will decrease coverage by 0.09%.
The diff coverage is 38.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3717      +/-   ##
==========================================
- Coverage   67.65%   67.56%   -0.10%     
==========================================
  Files         181      182       +1     
  Lines        8772     8818      +46     
==========================================
+ Hits         5935     5958      +23     
- Misses       2804     2827      +23     
  Partials       33       33              
Flag Coverage Δ
unittests 67.56% <38.55%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/osm-controller/log_handler.go 77.77% <0.00%> (-6.23%) ⬇️
cmd/osm-controller/osm-controller.go 13.33% <0.00%> (-0.19%) ⬇️
pkg/catalog/egress.go 83.89% <0.00%> (-3.72%) ⬇️
pkg/catalog/inbound_traffic_policies.go 78.81% <0.00%> (-4.23%) ⬇️
pkg/catalog/outbound_traffic_policies.go 83.24% <16.66%> (-4.12%) ⬇️
pkg/envoy/lds/gateway.go 84.44% <100.00%> (+1.51%) ⬆️
pkg/envoy/lds/inmesh.go 78.66% <100.00%> (+1.42%) ⬆️
pkg/errcode/errcode.go 100.00% <100.00%> (ø)
pkg/service/service.go 100.00% <100.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d7b04...4af79f1. Read the comment docs.

@shashankram shashankram merged commit bab143c into openservicemesh:main Jul 1, 2021
@shashankram shashankram deleted the err-v1 branch July 1, 2021 21:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants