This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 276
tests(e2e): fix port issues for remaining e2es on OpenShift #3756
Merged
SanyaKochhar
merged 1 commit into
openservicemesh:main
from
SanyaKochhar:e2e-deployment-test-fix
Jul 14, 2021
Merged
tests(e2e): fix port issues for remaining e2es on OpenShift #3756
SanyaKochhar
merged 1 commit into
openservicemesh:main
from
SanyaKochhar:e2e-deployment-test-fix
Jul 14, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3756 +/- ##
==========================================
- Coverage 69.98% 69.98% -0.01%
==========================================
Files 185 185
Lines 10366 10379 +13
==========================================
+ Hits 7255 7264 +9
- Misses 3062 3066 +4
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
SanyaKochhar
force-pushed
the
e2e-deployment-test-fix
branch
from
July 13, 2021 22:39
5089a39
to
e4aa581
Compare
SanyaKochhar
changed the title
[wip] tests(e2e): fix port issues for remaining e2es on OpenShift
tests(e2e): fix port issues for remaining e2es on OpenShift
Jul 13, 2021
ksubrmnn
approved these changes
Jul 13, 2021
nojnhuh
approved these changes
Jul 13, 2021
shashankram
suggested changes
Jul 13, 2021
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
SanyaKochhar
force-pushed
the
e2e-deployment-test-fix
branch
from
July 14, 2021 17:10
8ed4892
to
0be61da
Compare
shashankram
approved these changes
Jul 14, 2021
@Mergifyio backport release-v0.9 |
Command
|
nshankar13
added a commit
that referenced
this pull request
Jul 28, 2021
…/pr-3756 tests(e2e): fix port issues for remaining e2es on OpenShift (backport #3756)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Changes port used in tests to 14001 since OpenShift uses port 80 itself
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? no
Is this a breaking change? no