Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

tests(e2e): fix port issues for remaining e2es on OpenShift #3756

Merged

Conversation

SanyaKochhar
Copy link
Contributor

Description: Changes port used in tests to 14001 since OpenShift uses port 80 itself

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [x]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

@SanyaKochhar SanyaKochhar requested a review from ksubrmnn July 12, 2021 21:39
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2021

Codecov Report

Merging #3756 (c5a33c3) into main (32b9a78) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3756      +/-   ##
==========================================
- Coverage   69.98%   69.98%   -0.01%     
==========================================
  Files         185      185              
  Lines       10366    10379      +13     
==========================================
+ Hits         7255     7264       +9     
- Misses       3062     3066       +4     
  Partials       49       49              
Flag Coverage Δ
unittests 69.98% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/envoy/cds/response.go 80.00% <0.00%> (-4.13%) ⬇️
pkg/envoy/bootstrap/config.go 93.95% <0.00%> (-1.94%) ⬇️
pkg/envoy/cds/cluster.go 94.04% <0.00%> (-1.11%) ⬇️
pkg/errcode/errcode.go 100.00% <0.00%> (ø)
...icate/providers/certmanager/certificate_manager.go 86.61% <0.00%> (+0.70%) ⬆️
pkg/crdconversion/crdconversion.go 72.22% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b9a78...c5a33c3. Read the comment docs.

@SanyaKochhar SanyaKochhar force-pushed the e2e-deployment-test-fix branch from 5089a39 to e4aa581 Compare July 13, 2021 22:39
@SanyaKochhar SanyaKochhar linked an issue Jul 13, 2021 that may be closed by this pull request
@SanyaKochhar SanyaKochhar marked this pull request as ready for review July 13, 2021 22:40
@SanyaKochhar SanyaKochhar requested a review from a team as a code owner July 13, 2021 22:40
@SanyaKochhar SanyaKochhar changed the title [wip] tests(e2e): fix port issues for remaining e2es on OpenShift tests(e2e): fix port issues for remaining e2es on OpenShift Jul 13, 2021
tests/framework/common.go Outdated Show resolved Hide resolved
tests/framework/common.go Outdated Show resolved Hide resolved
tests/framework/common.go Outdated Show resolved Hide resolved
tests/framework/common.go Outdated Show resolved Hide resolved
Signed-off-by: Sanya Kochhar <kochhars@microsoft.com>
@SanyaKochhar SanyaKochhar force-pushed the e2e-deployment-test-fix branch from 8ed4892 to 0be61da Compare July 14, 2021 17:10
@SanyaKochhar SanyaKochhar requested a review from shashankram July 14, 2021 17:10
@SanyaKochhar SanyaKochhar merged commit 72b14d0 into openservicemesh:main Jul 14, 2021
@SanyaKochhar SanyaKochhar deleted the e2e-deployment-test-fix branch July 14, 2021 18:52
@nshankar13
Copy link
Contributor

@Mergifyio backport release-v0.9

@mergify
Copy link
Contributor

mergify bot commented Jul 27, 2021

Command backport release-v0.9: success

Backports have been created

nshankar13 added a commit that referenced this pull request Jul 28, 2021
…/pr-3756

tests(e2e): fix port issues for remaining e2es on OpenShift (backport #3756)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configure e2es to run on OpenShift
6 participants