Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

pkg/envoy/*: add error codes for Envoy RDS and SDS #3762

Merged
merged 1 commit into from
Jul 26, 2021

Conversation

jaellio
Copy link
Contributor

@jaellio jaellio commented Jul 14, 2021

Description:

Adds error codes for errors related to Envoy RDS and SDS.

Part of #2866

Affected area:

Functional Area
New Functionality [ ]
Documentation [ ]
Install [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Ingress [ ]
Egress [ ]
Networking [ ]
Observability [ ]
SMI Policy [ ]
Sidecar Injection [ ]
Security [ ]
Upgrade [ ]
Tests [ ]
CI System [ ]
Demo [ ]
Performance [ ]
Other [ X ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? No

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? No

@jaellio jaellio force-pushed the envoyRDSErrorCodes branch from 55983c2 to c881fcd Compare July 14, 2021 21:43
@jaellio jaellio marked this pull request as ready for review July 14, 2021 21:44
@jaellio jaellio requested a review from a team as a code owner July 14, 2021 21:44
Copy link
Member

@shashankram shashankram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments to clarify the error codes that should be updated both in the description map and the variable comment (if applicable).

pkg/errcode/errcode.go Outdated Show resolved Hide resolved
pkg/errcode/errcode.go Outdated Show resolved Hide resolved
pkg/errcode/errcode.go Outdated Show resolved Hide resolved
pkg/errcode/errcode.go Outdated Show resolved Hide resolved
pkg/errcode/errcode.go Outdated Show resolved Hide resolved
pkg/errcode/errcode.go Outdated Show resolved Hide resolved
@jaellio jaellio marked this pull request as draft July 15, 2021 16:26
@jaellio jaellio force-pushed the envoyRDSErrorCodes branch from c881fcd to 79975f9 Compare July 15, 2021 17:42
@jaellio jaellio marked this pull request as ready for review July 15, 2021 18:31
@jaellio jaellio force-pushed the envoyRDSErrorCodes branch from 79975f9 to 8b88525 Compare July 16, 2021 20:43
Adds error codes for errors related to Envoy RDS and SDS.

Part of openservicemesh#2866

Signed-off-by: jaellio <jaellio@microsoft.com>
@jaellio jaellio force-pushed the envoyRDSErrorCodes branch from 8b88525 to 039d278 Compare July 26, 2021 18:28
@jaellio jaellio merged commit 876fc8c into openservicemesh:main Jul 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants