Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

ref(crds): Rename CRD's in OSM #3810

Merged
merged 1 commit into from
Jul 20, 2021

Conversation

snehachhabria
Copy link
Contributor

Description:

Renamed CRD's in OSM

Signed-off-by: Sneha Chhabria snchh@microsoft.com

Affected area:

Functional Area
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change? no

Renamed CRD's in OSM

Signed-off-by: Sneha Chhabria <snchh@microsoft.com>
@snehachhabria snehachhabria requested a review from a team as a code owner July 20, 2021 20:45
@codecov-commenter
Copy link

Codecov Report

Merging #3810 (a74572e) into main (ab48487) will decrease coverage by 0.93%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3810      +/-   ##
==========================================
- Coverage   68.35%   67.42%   -0.94%     
==========================================
  Files         189      198       +9     
  Lines       10767    10926     +159     
==========================================
+ Hits         7360     7367       +7     
- Misses       3358     3510     +152     
  Partials       49       49              
Flag Coverage Δ
unittests 67.42% <ø> (-0.94%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/k8s/announcement_handlers.go 72.97% <0.00%> (-5.41%) ⬇️
pkg/crdconversion/framework.go 0.00% <0.00%> (ø)
...onversion/config_multiclusterservice_conversion.go 0.00% <0.00%> (ø)
pkg/crdconversion/config_meshconfig_conversion.go 0.00% <0.00%> (ø)
pkg/crdconversion/smi_httproutegroup_conversion.go 0.00% <0.00%> (ø)
pkg/crdconversion/smi_trafficsplit_conversion.go 0.00% <0.00%> (ø)
...crdconversion/policy_ingressbackends_conversion.go 0.00% <0.00%> (ø)
pkg/crdconversion/smi_trafficaccess_conversion.go 0.00% <0.00%> (ø)
pkg/crdconversion/smi_tcproutes_conversion.go 0.00% <0.00%> (ø)
pkg/crdconversion/policy_egress_conversion.go 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab48487...a74572e. Read the comment docs.

Copy link
Contributor

@draychev draychev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎇

@snehachhabria snehachhabria merged commit 6a113b2 into openservicemesh:main Jul 20, 2021
@snehachhabria snehachhabria deleted the renameCrds branch July 22, 2021 22:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants