This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
sds/test: fix test bug and expectation #3834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes the following test bugs: 1. Requested SDS secrets do not correspond to the proxy's namespaced service account name. 2. XDS cert CN is not fully qualified with the trust domain. As a result of these bugs, the test expectation was also incorrect, which has been addressed in this change. Signed-off-by: Shashank Ram <shashr2204@gmail.com>
allenlsy
approved these changes
Jul 22, 2021
snehachhabria
approved these changes
Jul 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change fixes the following test bugs:
namespaced service account name.
As a result of these bugs, the test expectation was also incorrect,
which is resolved in this change.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
no