Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

feat(*): add traffic split in permissive mode #4023

Closed
wants to merge 2 commits into from

Conversation

michelleN
Copy link
Contributor

resolves #2527

Signed-off-by: Michelle Noorali minooral@microsoft.com

Please describe how this change was tested. You could include supporting information
such as logs, snippets, and screenshots.

-->
Testing done:

Affected area:

Functional Area
New Functionality [ ]
CI System [ ]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [ ]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

@michelleN michelleN requested a review from a team as a code owner August 23, 2021 16:28
@michelleN michelleN marked this pull request as draft August 23, 2021 16:28
@michelleN michelleN added this to the v0.10.0 milestone Aug 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #4023 (9193083) into main (f78e72f) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4023      +/-   ##
==========================================
+ Coverage   67.48%   67.50%   +0.02%     
==========================================
  Files         204      204              
  Lines       11615    11636      +21     
==========================================
+ Hits         7838     7855      +17     
- Misses       3726     3730       +4     
  Partials       51       51              
Flag Coverage Δ
unittests 67.50% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/catalog/outbound_traffic_policies.go 83.83% <100.00%> (-0.25%) ⬇️
pkg/cli/environment.go 78.26% <0.00%> (-21.74%) ⬇️
pkg/crdconversion/crdconversion.go 69.56% <0.00%> (-2.18%) ⬇️
cmd/cli/mesh.go 100.00% <0.00%> (ø)
pkg/errcode/errcode.go 100.00% <0.00%> (ø)
pkg/providers/kube/client.go 64.81% <0.00%> (+0.61%) ⬆️
cmd/cli/osm.go 82.50% <0.00%> (+1.41%) ⬆️
pkg/ingress/client.go 79.82% <0.00%> (+1.85%) ⬆️
cmd/cli/env.go 50.00% <0.00%> (+3.33%) ⬆️
pkg/certificate/providers/tresor/certificate.go 100.00% <0.00%> (+4.34%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f78e72f...9193083. Read the comment docs.

@draychev draychev modified the milestones: v0.10.0, v1.0.0 Aug 23, 2021
@michelleN michelleN force-pushed the permissivesplit branch 4 times, most recently from 60f9f52 to 65a35eb Compare August 24, 2021 20:54
@michelleN michelleN marked this pull request as ready for review August 24, 2021 20:55
@michelleN michelleN force-pushed the permissivesplit branch 5 times, most recently from 5e22b6c to 50345e0 Compare August 31, 2021 17:08
Michelle Noorali added 2 commits September 1, 2021 13:40
Signed-off-by: Michelle Noorali <minooral@microsoft.com>
resolves openservicemesh#2527

Signed-off-by: Michelle Noorali <minooral@microsoft.com>
@shashankram
Copy link
Member

Issue #2527 has been resolved via #4074. This change should no longer be necessary.

@shashankram shashankram added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 7, 2021
@michelleN michelleN closed this Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement traffic split in permissive mode
4 participants