Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

chore(*): update osm install demo #4114

Merged
merged 1 commit into from
Sep 16, 2021

Conversation

shalier
Copy link
Contributor

@shalier shalier commented Sep 15, 2021

Description:
Updates OSM install demo and links in README.md
Resolves #2279

Signed-off-by: Shalier Xia shalierxia@microsoft.com

Testing done:

Affected area:

Functional Area
Demo [x ]
Documentation [x ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?no

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?no

@shalier shalier requested a review from a team as a code owner September 15, 2021 00:57
@codecov-commenter
Copy link

codecov-commenter commented Sep 15, 2021

Codecov Report

Merging #4114 (3415168) into main (5e9a349) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4114      +/-   ##
==========================================
+ Coverage   69.12%   69.18%   +0.05%     
==========================================
  Files         205      205              
  Lines       11240    11240              
==========================================
+ Hits         7770     7776       +6     
+ Misses       3418     3412       -6     
  Partials       52       52              
Flag Coverage Δ
unittests 69.18% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/providers/kube/client.go 71.68% <0.00%> (+0.88%) ⬆️
pkg/crdconversion/crdconversion.go 75.00% <0.00%> (+5.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e9a349...3415168. Read the comment docs.

@@ -99,13 +99,13 @@ sudo mv ./osm /usr/local/bin/osm
```shell
$ osm install
```
![OSM Install Demo](img/osm-install-demo-v0.2.0.gif "OSM Install Demo")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please git rm img/osm-install-demo-v0.2.0.gif.

@shalier shalier force-pushed the osmInstallDemo branch 2 times, most recently from 4ec10ce to 9495127 Compare September 15, 2021 18:37
@shalier shalier requested a review from shashankram September 15, 2021 18:37
Updates OSM install demo and links in README.md
Resolves openservicemesh#2279

Signed-off-by: Shalier Xia <shalierxia@microsoft.com>
@mergify mergify bot merged commit b760f6b into openservicemesh:main Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation GIF is outdated
4 participants