This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
ref(chart): push vault validation to chart #4513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the validation for the `osm.vault.host` and `osm.vault.token` values from the CLI to the chart so the same validation is performed when using `helm` directly. Part of #2147 Signed-off-by: Jon Huhn <johuhn@microsoft.com>
nojnhuh
requested review from
draychev,
jaellio,
shashankram and
snehachhabria
as code owners
shashankram
approved these changes
Feb 8, 2022
trstringer
approved these changes
Feb 8, 2022
snehachhabria
approved these changes
Feb 8, 2022
jaellio
approved these changes
Feb 8, 2022
schristoff
pushed a commit
to schristoff/osm
that referenced
this pull request
Feb 22, 2022
This change moves the validation for the `osm.vault.host` and `osm.vault.token` values from the CLI to the chart so the same validation is performed when using `helm` directly. Part of openservicemesh#2147 Signed-off-by: Jon Huhn <johuhn@microsoft.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This change moves the validation for the
osm.vault.hostandosm.vault.tokenvalues from the CLI to the chart so the samevalidation is performed when using
helmdirectly.Part of #2147
Testing done: Unit tests updated.
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project? No
Is this a breaking change? No
Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? N/A