-
Notifications
You must be signed in to change notification settings - Fork 276
doc: Update links in docs #4519
doc: Update links in docs #4519
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't resolve the issue; the diagram isn't a true representation of OSM anymore and needs to be updated. That's the requirement of the issue
ad5591f
to
401ca4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The diagram is still incorrect; injector isn't a part of osm-controller anymore. osm-bootstrap is missing.
- Integration to Vault and cert manager is missing
- Prometheus and grafana doesn't pull metrics from application pods only, it pulls metrics from the control plane as well
These are just a few of the inconsistencies, please refer the code to get an idea of the architecture. this will help improve the diagram
401ca4b
to
9ce92e4
Compare
@snehachhabria Diagram updated per feedback. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions on the diagram:
- Tresor is missing as one of the cert managers
- we can indicate that the mesh config is created from osm-bootstrap
- osm-injector creates the sidecar on the k8s pod, this needs to be indicated
9ce92e4
to
4f65ef0
Compare
The image updates look good @allenlsy. If you used Google doc to create the image, would you mind sharing a link to the google doc hosting the image just in case we need to update it in the future? Was discussing with @trstringer about how to keep the images up to date, and we felt it would be best to use Google doc/slides to create images so we can easily edit them in the future. |
Update links to source code files in the OSM Components & Interactions and Design documents. Signed-off-by: Allen Leigh <allenlsy@gmail.com>
4f65ef0
to
193d379
Compare
Description:
Update links to source code files in the OSM Components & Interactions and Design
documents.
Diagram link:
Resolves #4226
Testing done:
There is no code change.
Affected area:
Please answer the following questions with yes/no.
No
No
No