Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Add openshift SCC zookeeper #4787

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

nshankar13
Copy link
Contributor

@nshankar13 nshankar13 commented Jun 3, 2022

Signed-off-by: nshankar13 nshankar@microsoft.com

Description: Add SecuityContextConstraint for zookeeper SA in e2e_statefulsets_test for OpenShift.

Resolves #4784

Testing done: Tested locally on OpenShift cluster.

Affected area:

Functional Area
New Functionality [ ]
CI System [X]
CLI Tool [ ]
Certificate Management [ ]
Control Plane [ ]
Demo [ ]
Documentation [ ]
Egress [ ]
Ingress [ ]
Install [ ]
Networking [ ]
Observability [ ]
Performance [ ]
SMI Policy [ ]
Security [ ]
Sidecar Injection [ ]
Tests [X]
Upgrade [ ]
Other [ ]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project?

    • Did you notify the maintainers and provide attribution?
  2. Is this a breaking change?

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)?

@codecov-commenter
Copy link

Codecov Report

Merging #4787 (13c91f9) into main (c24012f) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4787      +/-   ##
==========================================
+ Coverage   68.91%   68.92%   +0.01%     
==========================================
  Files         224      224              
  Lines       16388    16388              
==========================================
+ Hits        11293    11296       +3     
+ Misses       5043     5040       -3     
  Partials       52       52              
Flag Coverage Δ
unittests 68.92% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/messaging/workqueue.go 100.00% <0.00%> (+10.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24012f...13c91f9. Read the comment docs.

@nshankar13 nshankar13 force-pushed the sa_openshift_statefulsets branch from 13c91f9 to 4c7b7b5 Compare June 3, 2022 16:45
Signed-off-by: nshankar13 <nshankar@microsoft.com>
@nshankar13 nshankar13 marked this pull request as draft June 3, 2022 17:28
@nshankar13 nshankar13 marked this pull request as ready for review June 3, 2022 17:32
@nshankar13 nshankar13 marked this pull request as draft June 3, 2022 17:33
@nshankar13 nshankar13 marked this pull request as ready for review June 3, 2022 20:17
@jaellio jaellio merged commit dd5ec72 into openservicemesh:main Jun 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OpenShift Nightly Job Failing
4 participants