This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
envoy|catalog: use TrafficMatch to build inbound filter config #4814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to how outbound filter config is built, this change relies on the TrafficMatch type to build inbound filter configs. The TrafficMatch has a 1-1 mapping to an Envoy filter_chain config. This is necessary to be able to cleanly apply TrafficMatch based policies (e.g. rate limiting) without needing to rely on multiple catalog APIs. Part of openservicemesh#2018 Signed-off-by: Shashank Ram <shashr2204@gmail.com>
shashankram
requested review from
snehachhabria,
nojnhuh,
draychev,
jaellio and
trstringer
as code owners
nojnhuh
approved these changes
Jun 14, 2022
jaellio
approved these changes
Jun 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Similar to how outbound filter config is built, this change
relies on the TrafficMatch type to build inbound filter
configs. The TrafficMatch has a 1-1 mapping to an Envoy
filter_chain config. This is necessary to be able to
cleanly apply TrafficMatch based policies (e.g. rate
limiting) without needing to rely on multiple catalog
APIs.
Part of #2018
Testing done:
Unit tests, CI
Affected area:
Please answer the following questions with yes/no.
Does this change contain code from or inspired by another project?
noIs this a breaking change?
noHas documentation corresponding to this change been updated in the osm-docs repo (if applicable)?
n/a