Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

Add GitHub Action to require size and kind labels #4876

Merged

Conversation

trstringer
Copy link
Contributor

Currently there is no enforcement of adding size/* or kind/* labels
to issues. This will help the project and collaborators understand the
type of issue, as well as a rough estimate of how long it is projected
to take to resolve.

This PR adds the workflow to mark issues with size/needed in the
absence of size/* labels, and kind/needed in the absence of kind/*
labels. This will only consider issues that are part of a milestone.

Signed-off-by: Thomas Stringer thomas@trstringer.com

Affected area:

Functional Area
Other [X]

Please answer the following questions with yes/no.

  1. Does this change contain code from or inspired by another project? Yes, this change uses a custom GitHub action, trstringer/require-label-prefix.

    • Did you notify the maintainers and provide attribution? I am the maintainer of the project.
  2. Is this a breaking change? No.

  3. Has documentation corresponding to this change been updated in the osm-docs repo (if applicable)? N/A

Currently there is no enforcement of adding `size/*` or `kind/*` labels
to issues. This will help the project and collaborators understand the
type of issue, as well as a rough estimate of how long it is projected
to take to resolve.

This PR adds the workflow to mark issues with `size/needed` in the
absence of `size/*` labels, and `kind/needed` in the absence of `kind/*`
labels. This will only consider issues that are part of a milestone.

Signed-off-by: Thomas Stringer <thomas@trstringer.com>
@codecov-commenter
Copy link

Codecov Report

Merging #4876 (9cdd289) into main (aa1abf1) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4876      +/-   ##
==========================================
- Coverage   68.71%   68.69%   -0.02%     
==========================================
  Files         220      220              
  Lines       15907    15907              
==========================================
- Hits        10930    10927       -3     
- Misses       4925     4928       +3     
  Partials       52       52              
Flag Coverage Δ
unittests 68.69% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/messaging/workqueue.go 89.28% <0.00%> (-10.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa1abf1...9cdd289. Read the comment docs.

@trstringer
Copy link
Contributor Author

Image scan failure is a known issue: alpinelinux/docker-alpine#261.

Signed-off-by: Thomas Stringer <thomas@trstringer.com>
@trstringer trstringer requested a review from jaellio July 7, 2022 18:45
@trstringer trstringer merged commit 4da737e into openservicemesh:main Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants