-
Notifications
You must be signed in to change notification settings - Fork 276
update release versions and image digests #4886
Conversation
Where do I do this? I don't see this documented anywhere? Would this not be done in the docs repo? https://github.com/openservicemesh/osm-docs/blob/main/manifests/apps/bookbuyer.yaml#L34 |
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
I'm pretty sure that refers to changing these which should be documented with the steps to cut a release of the docs: https://github.com/openservicemesh/osm-docs/blob/98c728ce7056d550599f13a5ee03fbb7d0649e52/manifests/apps/bookstore.yaml#L49 That must be left over from before the manual demo manifests were moved to the docs repo. |
Codecov Report
@@ Coverage Diff @@
## release-v1.2 #4886 +/- ##
=============================================
Coverage 68.72% 68.72%
=============================================
Files 220 220
Lines 15914 15914
=============================================
Hits 10937 10937
Misses 4925 4925
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the changes Jon requested
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
For all release-related PR are people in favor of using the chore(release) prefix or are people in favor of dropping this schema? Curious to hear others' thoughts. I find the prefixes helpful when searching for old PRs. |
Signed-off-by: Sean Teeling seanteeling@microsoft.com
I have cherry-picked any changes labelled
needs-cherry-pick-vX.Y.Z
I have made all of the following version and patch updates:
I have checked that the base branch for this PR is correct as defined by the release guide
Is this a release candidate?