Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

update release versions and image digests #4886

Merged
merged 4 commits into from
Jul 12, 2022

Conversation

steeling
Copy link
Contributor

@steeling steeling commented Jul 12, 2022

Signed-off-by: Sean Teeling seanteeling@microsoft.com

  • I have cherry-picked any changes labelled needs-cherry-pick-vX.Y.Z

  • I have made all of the following version and patch updates:

    1. Updated the container image tag in charts/osm/values.yaml
    2. Updated the chart and app version in charts/osm/Chart.yaml
    3. Updated the image tags used in the automated demo
    4. Regenerated the Helm chart README.md
  • I have checked that the base branch for this PR is correct as defined by the release guide

Is this a release candidate?

@steeling
Copy link
Contributor Author

steeling commented Jul 12, 2022

Updated the image tags used in the automated demo

Where do I do this? I don't see this documented anywhere? Would this not be done in the docs repo? https://github.com/openservicemesh/osm-docs/blob/main/manifests/apps/bookbuyer.yaml#L34

@nojnhuh

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
@nojnhuh
Copy link
Contributor

nojnhuh commented Jul 12, 2022

I'm pretty sure that refers to changing these which should be documented with the steps to cut a release of the docs: https://github.com/openservicemesh/osm-docs/blob/98c728ce7056d550599f13a5ee03fbb7d0649e52/manifests/apps/bookstore.yaml#L49

That must be left over from before the manual demo manifests were moved to the docs repo.

@steeling steeling marked this pull request as ready for review July 12, 2022 15:39
charts/osm/Chart.yaml Outdated Show resolved Hide resolved
tests/e2e/e2e_upgrade_test.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jul 12, 2022

Codecov Report

Merging #4886 (372ef30) into release-v1.2 (1da753b) will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           release-v1.2    #4886   +/-   ##
=============================================
  Coverage         68.72%   68.72%           
=============================================
  Files               220      220           
  Lines             15914    15914           
=============================================
  Hits              10937    10937           
  Misses             4925     4925           
  Partials             52       52           
Flag Coverage Δ
unittests 68.72% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1da753b...372ef30. Read the comment docs.

steeling added 2 commits July 12, 2022 12:32
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
tests/e2e/e2e_upgrade_test.go Outdated Show resolved Hide resolved
charts/osm/Chart.yaml Outdated Show resolved Hide resolved
keithmattix
keithmattix previously approved these changes Jul 12, 2022
Copy link
Contributor

@keithmattix keithmattix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the changes Jon requested

Signed-off-by: Sean Teeling <seanteeling@microsoft.com>
@jaellio
Copy link
Contributor

jaellio commented Jul 12, 2022

For all release-related PR are people in favor of using the chore(release) prefix or are people in favor of dropping this schema? Curious to hear others' thoughts. I find the prefixes helpful when searching for old PRs.

@steeling steeling merged commit d40f9b8 into openservicemesh:release-v1.2 Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants