Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin tenacity 8.3 #701

Merged
merged 1 commit into from
Jun 17, 2024
Merged

Pin tenacity 8.3 #701

merged 1 commit into from
Jun 17, 2024

Conversation

vfreex
Copy link
Contributor

@vfreex vfreex commented Jun 17, 2024

8.4.0 is broken:

  File "/mnt/jenkins-workspace/aos-cd-builds_build_ocp4_scan/art-venv/lib64/python3.9/site-packages/tenacity/__init__.py", line 653, in <module>
    from tenacity.asyncio import AsyncRetrying  # noqa:E402,I100
ModuleNotFoundError: No module named 'tenacity.asyncio'

@vfreex
Copy link
Contributor Author

vfreex commented Jun 17, 2024

jd/tenacity#471

@vfreex
Pin tenacity 8.3
d08d117 
8.4.0 is broken:

```
  File "/mnt/jenkins-workspace/aos-cd-builds_build_ocp4_scan/art-venv/lib64/python3.9/site-packages/tenacity/__init__.py", line 653, in <module>
    from tenacity.asyncio import AsyncRetrying  # noqa:E402,I100
ModuleNotFoundError: No module named 'tenacity.asyncio'
```
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

@vfreex: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d08d117 link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@Ximinhan Ximinhan added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 17, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit dbea69c into openshift-eng:main Jun 17, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vfreex @Ximinhan