-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OAPE-118: rename CFE to OAP #193
base: main
Are you sure you want to change the base?
Conversation
@KeenonLee: This pull request references OAPE-118 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: KeenonLee The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @KeenonLee. Thanks for your PR. I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
3456f42
to
16d7194
Compare
Hi @xingxingxia |
You can add ExcludeAny []string in https://github.com/openshift-eng/ci-test-mapping/blob/main/pkg/components/oauthapiserver/component.go :
|
27a0265
to
b1f48c9
Compare
After make mapping It seems that updating the ci-test-mapping/data/openshift-gce-devel/ci_analysis_qe/junit.json will be taken care of by openshift-trt bot automatically. Could you help check/merge? Thanks! @stbenjam |
also |
Tests can't move back to unknown, you have to fix that. This is changing the matchers on tests: -IncludeAll: []string{"CFE cert-manager"}, // cert-manager QE cases all have "CFE cert-manager" in junit xml
+IncludeAll: []string{"OAP cert-manager"}, // cert-manager QE cases all have "OAP cert-manager" in junit xml If tests are being renamed you have to follow the instructions in README.md to link the old and new names, but junit.json gets updated every day and there's no tests that mention /ok-to-test |
Also please join the openshift-eng org so your PR's get tested automatically |
Both OAP cert-manager and CFE cert-manager in junit.json |
You're still migrating tests to the Unknown component which isn't allowed "Name": "OCP-62006:geliu:CFE:[sig-auth] CFE cert-manager RH cert-manager operator can be uninstalled from CLI and then reinstalled [Serial]",
"Suite": "CFE",
"Product": "OpenShift",
"Priority": 0,
"StaffApprovedObsolete": false,
- "Component": "cert-manager",
+ "Component": "Unknown",
"Capabilities": [
"Other"
], |
Sorry sir @stbenjam , I don't know why it still exists "Name": "OCP-62006:geliu:CFE:[sig-auth] CFE cert-manager RH cert-manager operator can be uninstalled from CLI and then reinstalled [Serial]", {
"APIVersion": "v1",
"Kind": "TestOwnership",
"ID": "OAP:40eb141ffff3d24dba9a8d9fe41cbcd3",
"Name": "OCP-62006:geliu:OAP:[sig-oap] OAP cert-manager RH cert-manager operator can be uninstalled from CLI and then reinstalled [Serial]",
"Suite": "OAP",
"Product": "OpenShift",
"Priority": 0,
"StaffApprovedObsolete": false,
- "Component": "Unknown",
+ "Component": "cert-manager",
"Capabilities": [
"Other"
],
- "JIRAComponent": "Unknown",
- "JIRAComponentID": "12367926"
+ "JIRAComponent": "cert-manager",
+ "JIRAComponentID": "12375354"
}, |
@@ -153464,12 +153464,12 @@ | |||
"Product": "OpenShift", | |||
"Priority": 0, | |||
"StaffApprovedObsolete": false, | |||
"Component": "Unknown", | |||
"Component": "cert-manager", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Name": "OCP-62006:geliu:CFE:[sig-auth] CFE cert-manager RH cert-manager operator can be uninstalled from CLI and then reinstalled [Serial]",
has been renamed and exists at here
Please help to take a look, Thanks @stbenjam
https://issues.redhat.com/browse/OAPE-118
remane CFE (Customer Focus Engineering) to OAP (OpenShift Application Platform)
follow-up to update
https://github.com/openshift/openshift-tests-private/pull/23115
openshift/release#61494