Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAPE-118: rename CFE to OAP #193

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

KeenonLee
Copy link

https://issues.redhat.com/browse/OAPE-118
remane CFE (Customer Focus Engineering) to OAP (OpenShift Application Platform)

follow-up to update
https://github.com/openshift/openshift-tests-private/pull/23115
openshift/release#61494

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 12, 2025

@KeenonLee: This pull request references OAPE-118 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

https://issues.redhat.com/browse/OAPE-118
remane CFE (Customer Focus Engineering) to OAP (OpenShift Application Platform)

follow-up to update
https://github.com/openshift/openshift-tests-private/pull/23115
openshift/release#61494

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 12, 2025
@openshift-ci openshift-ci bot requested review from dgoodwin and neisw February 12, 2025 03:48
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KeenonLee
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 12, 2025
Copy link
Contributor

openshift-ci bot commented Feb 12, 2025

Hi @KeenonLee. Thanks for your PR.

I'm waiting for a openshift-eng member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@KeenonLee KeenonLee force-pushed the cfetooap branch 2 times, most recently from 3456f42 to 16d7194 Compare February 12, 2025 04:00
@KeenonLee
Copy link
Author

Hi @xingxingxia
After executing make mapping, it seems that the case is redrawn to auth. It should be to judge the value in junit?
Do we need to update the CFE to OAP in it?
ci-test-mapping/data/openshift-gce-devel/ci_analysis_qe/junit.json

@xingxingxia
Copy link
Contributor

You can add ExcludeAny []string in https://github.com/openshift-eng/ci-test-mapping/blob/main/pkg/components/oauthapiserver/component.go :

                        {
                                SIG:      "sig-auth",
                                Priority: -1,
+                               ExcludeAny: []string{"CFE cert-manager"}, // comment ....
                        },

@KeenonLee KeenonLee force-pushed the cfetooap branch 2 times, most recently from 27a0265 to b1f48c9 Compare February 12, 2025 08:46
@KeenonLee
Copy link
Author

After make mapping
The "Component": "cert-manager" ==> "Component": "Unknown" in data/openshift-gce-devel/ci_analysis_qe/component_mapping.json is incorrect

It seems that updating the ci-test-mapping/data/openshift-gce-devel/ci_analysis_qe/junit.json will be taken care of by openshift-trt bot automatically.

Could you help check/merge? Thanks! @stbenjam

@lunarwhite
Copy link

also
/cc @pruan-rht
for review. We are renaming the description of our test suite in the o/openshift-tests-private repo. TIA!

@openshift-ci openshift-ci bot requested a review from pruan-rht February 13, 2025 07:39
@stbenjam
Copy link
Collaborator

stbenjam commented Feb 14, 2025

Tests can't move back to unknown, you have to fix that.

This is changing the matchers on tests:

-IncludeAll: []string{"CFE cert-manager"}, // cert-manager QE cases all have "CFE cert-manager" in junit xml
+IncludeAll: []string{"OAP cert-manager"}, // cert-manager QE cases all have "OAP cert-manager" in junit xml

If tests are being renamed you have to follow the instructions in README.md to link the old and new names, but junit.json gets updated every day and there's no tests that mention OAP cert-manager. And the old tests CFE cert-manager cannot move to Unknown.

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 14, 2025
@stbenjam
Copy link
Collaborator

Also please join the openshift-eng org so your PR's get tested automatically

@KeenonLee
Copy link
Author

Both OAP cert-manager and CFE cert-manager in junit.json

@stbenjam
Copy link
Collaborator

You're still migrating tests to the Unknown component which isn't allowed

    "Name": "OCP-62006:geliu:CFE:[sig-auth] CFE cert-manager RH cert-manager operator can be uninstalled from CLI and then reinstalled [Serial]",
    "Suite": "CFE",
    "Product": "OpenShift",
    "Priority": 0,
    "StaffApprovedObsolete": false,
-    "Component": "cert-manager",
+    "Component": "Unknown",
    "Capabilities": [
      "Other"
    ],

@KeenonLee
Copy link
Author

KeenonLee commented Feb 24, 2025

Sorry sir @stbenjam , I don't know why it still exists "Name": "OCP-62006:geliu:CFE:[sig-auth] CFE cert-manager RH cert-manager operator can be uninstalled from CLI and then reinstalled [Serial]",
It has been renamed and exists in data/openshift-gce-devel/ci_analysis_qe/component_mapping.json

  {
    "APIVersion": "v1",
    "Kind": "TestOwnership",
    "ID": "OAP:40eb141ffff3d24dba9a8d9fe41cbcd3",
    "Name": "OCP-62006:geliu:OAP:[sig-oap] OAP cert-manager RH cert-manager operator can be uninstalled from CLI and then reinstalled [Serial]",
    "Suite": "OAP",
    "Product": "OpenShift",
    "Priority": 0,
    "StaffApprovedObsolete": false,
-    "Component": "Unknown",
+    "Component": "cert-manager",
    "Capabilities": [
      "Other"
    ],
-    "JIRAComponent": "Unknown",
-    "JIRAComponentID": "12367926"
+    "JIRAComponent": "cert-manager",
+    "JIRAComponentID": "12375354"
  },

@@ -153464,12 +153464,12 @@
"Product": "OpenShift",
"Priority": 0,
"StaffApprovedObsolete": false,
"Component": "Unknown",
"Component": "cert-manager",
Copy link
Author

@KeenonLee KeenonLee Feb 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Name": "OCP-62006:geliu:CFE:[sig-auth] CFE cert-manager RH cert-manager operator can be uninstalled from CLI and then reinstalled [Serial]",
has been renamed and exists at here
Please help to take a look, Thanks @stbenjam

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants