Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.12] kafka broker now supports all kafka topic config options (#3671) #1031

Merged
merged 1 commit into from
Mar 21, 2024
Merged

[release-v1.12] kafka broker now supports all kafka topic config options (#3671) #1031

merged 1 commit into from
Mar 21, 2024

Conversation

Cali0707
Copy link
Member

@Cali0707
feat: kafka broker now supports all kafka topic config options (knati…
60c6834 
…ve-extensions#3671)

* feat: kafka broker now supports all kafka topic config options

Signed-off-by: Calum Murray <cmurray@redhat.com>

* test: added unit tests, fixed existing tests

Signed-off-by: Calum Murray <cmurray@redhat.com>

---------

Signed-off-by: Calum Murray <cmurray@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and matzew March 19, 2024 17:33
@matzew
Copy link
Member

matzew commented Mar 20, 2024

/test 414-test-reconciler-encryption-auth-aws-414

matzew
matzew approved these changes Mar 20, 2024
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Mar 20, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 20d343c and 2 for PR HEAD 60c6834 in total

@Cali0707
Copy link
Member Author

/retest-required

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Mar 20, 2024

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/414-test-reconciler-encryption-auth-aws-414 60c6834 link true /test 414-test-reconciler-encryption-auth-aws-414

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2eb9b2f into openshift-knative:release-v1.12 Mar 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

Assignees

@matzew matzew

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Cali0707 @matzew @openshift-ci-robot