Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.11] Expose init offset and schedule metrics for ConsumerGroup reconciler (#790) #792

Closed

Conversation

pierDipi
Copy link
Member

Manual CP of #790

@openshift-ci openshift-ci bot requested review from creydr and lberk August 22, 2023 13:21
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD fdc5140 and 2 for PR HEAD a8363ad in total

@matzew
Copy link
Member

matzew commented Aug 22, 2023

/retest

2 similar comments
@matzew
Copy link
Member

matzew commented Aug 23, 2023

/retest

@matzew
Copy link
Member

matzew commented Aug 29, 2023

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 91d4345 and 1 for PR HEAD a8363ad in total

@openshift-ci openshift-ci bot removed the lgtm label Aug 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Aug 30, 2023

New changes are detected. LGTM label has been removed.

@pierDipi
Copy link
Member Author

pierDipi commented Sep 1, 2023

/lgtm

@pierDipi pierDipi requested a review from matzew September 1, 2023 07:20
@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2023

@pierDipi: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link

openshift-ci bot commented Sep 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi
Copy link
Member Author

pierDipi commented Sep 7, 2023

/test 413-test-reconciler-aws-ocp-413

@pierDipi
Copy link
Member Author

pierDipi commented Sep 7, 2023

/retest-required

1 similar comment
@pierDipi
Copy link
Member Author

/retest-required

@openshift-ci
Copy link

openshift-ci bot commented Sep 20, 2023

@pierDipi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/410-test-conformance-aws-ocp-410 6ca80ab link true /test 410-test-conformance-aws-ocp-410
ci/prow/410-test-reconciler-aws-ocp-410 6ca80ab link true /test 410-test-reconciler-aws-ocp-410
ci/prow/410-images 6ca80ab link true /test 410-images
ci/prow/410-test-e2e-aws-ocp-410 6ca80ab link true /test 410-test-e2e-aws-ocp-410
ci/prow/411-test-reconciler-aws-ocp-411 87dbf44 link true /test 411-test-reconciler-aws-ocp-411
ci/prow/413-test-reconciler-aws-ocp-413 87dbf44 link true /test 413-test-reconciler-aws-ocp-413

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pierDipi pierDipi closed this Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants