Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.9] Scheduler handles overcommitted pods #819

Merged

Conversation

pierDipi
Copy link
Member

@pierDipi pierDipi commented Sep 8, 2023

This patch will handle these 2 other cases:

		{
			name:      "two replicas, 12 vreplicas, already scheduled on overcommitted pod, remove replicas",
			vreplicas: 12,
			replicas:  int32(2),
			placements: []duckv1alpha1.Placement{
				{PodName: "statefulset-name-0", VReplicas: 12},
			},
			expected: []duckv1alpha1.Placement{
				{PodName: "statefulset-name-0", VReplicas: 10},
				{PodName: "statefulset-name-1", VReplicas: 2},
			},
			schedulerPolicyType: scheduler.MAXFILLUP,
		},
		{
			name:      "one replica, 12 vreplicas, already scheduled on overcommitted pod, remove replicas",
			vreplicas: 12,
			replicas:  int32(1),
			placements: []duckv1alpha1.Placement{
				{PodName: "statefulset-name-0", VReplicas: 12},
			},
			expected: []duckv1alpha1.Placement{
				{PodName: "statefulset-name-0", VReplicas: 10},
			},
			err:                 controller.NewRequeueAfter(5 * time.Second),
			schedulerPolicyType: scheduler.MAXFILLUP,
		},

by rescheduling exceeding virtual replicas on overcommitted pods

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
@pierDipi pierDipi changed the title Scheduler handle overcommitted pods Scheduler handles overcommitted pods Sep 8, 2023
@openshift-ci openshift-ci bot requested review from aliok and matzew September 8, 2023 09:10
@pierDipi pierDipi changed the title Scheduler handles overcommitted pods [release-v1.9] Scheduler handles overcommitted pods Sep 8, 2023
@openshift-ci openshift-ci bot added the approved label Sep 8, 2023
@pierDipi
Copy link
Member Author

pierDipi commented Sep 8, 2023

/cc @matzew @creydr

@openshift-ci openshift-ci bot requested a review from creydr September 8, 2023 11:24
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew matzew merged commit 918b963 into openshift-knative:release-v1.9 Sep 8, 2023
@pierDipi
Copy link
Member Author

pierDipi commented Sep 8, 2023

/cherry-pick release-v1.10

@pierDipi pierDipi deleted the handle-overcommitted-pods branch September 8, 2023 12:27
@openshift-cherrypick-robot

@pierDipi: new pull request created: #820

In response to this:

/cherry-pick release-v1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants