Skip to content

Commit

Permalink
🔥 Apply carried patches.
Browse files Browse the repository at this point in the history
  • Loading branch information
alanfx committed Nov 14, 2021
1 parent 8b3f286 commit 0e4425d
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 5 deletions.
1 change: 1 addition & 0 deletions pkg/common/client/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,7 @@ func (b *configBuilder) Build(ctx context.Context) (*sarama.Config, error) {

// We Always Want Success Messages From Producer
config.Producer.Return.Successes = true
config.Producer.RequiredAcks = sarama.WaitForAll
}

// then apply stuff from YAML
Expand Down
2 changes: 1 addition & 1 deletion test/e2e/helpers/kafka_helper.go
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ const (
strimziTopicResource = "kafkatopics"
interval = 3 * time.Second
timeout = 30 * time.Second
kafkaCatImage = "docker.io/edenhill/kafkacat:1.6.0"
kafkaCatImage = "quay.io/openshift-knative/kafkacat:1.6.0"
)

var (
Expand Down
2 changes: 1 addition & 1 deletion test/rekt/resources/kafkacat/kafkacat.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ metadata:
namespace: {{ .namespace }}
spec:
containers:
- image: docker.io/edenhill/kafkacat:1.6.0
- image: quay.io/openshift-knative/kafkacat:1.6.0
name: producer-container
command:
- kafkacat
Expand Down
4 changes: 2 additions & 2 deletions test/rekt/resources/kafkacat/kafkacat_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func Example_min() {
// namespace: bar
// spec:
// containers:
// - image: docker.io/edenhill/kafkacat:1.6.0
// - image: quay.io/openshift-knative/kafkacat:1.6.0
// name: producer-container
// command:
// - kafkacat
Expand Down Expand Up @@ -109,7 +109,7 @@ func Example_full() {
// namespace: bar
// spec:
// containers:
// - image: docker.io/edenhill/kafkacat:1.6.0
// - image: quay.io/openshift-knative/kafkacat:1.6.0
// name: producer-container
// command:
// - kafkacat
Expand Down
2 changes: 1 addition & 1 deletion vendor/knative.dev/pkg/version/version.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ const (
// NOTE: If you are changing this line, please also update the minimum kubernetes
// version listed here:
// https://github.com/knative/docs/blob/mkdocs/docs/snippets/prerequisites.md
defaultMinimumVersion = "v1.20.0"
defaultMinimumVersion = "v1.19.0"
)

func getMinimumVersion() string {
Expand Down

0 comments on commit 0e4425d

Please sign in to comment.