[0.21] Backport of (#433) (#481) #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@devguyio Is it possible to rebase this ? |
|
@matzew sure |
) * Add Subscription prober Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Fix endpoints informer in cons. KafkaChannel controller * Fix unittests after adding status prober Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Format and order go imports in cons. channel controller Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Rename import alias and remove unused variable Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Add dispatcher prober test for tesitng a single pod Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Support probing dispatchers for multiple partitions kafka channels Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Update deps Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Fix conumer handler test Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * remove unused hashes from status probing test Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Apply review comments and add a prober test Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Remove old comment Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Fix fake status manager Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Return error if IsReady returns an error Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Change probing to be partition based and fix some corner cases of channel deletion * Change cleanup logic to clean ready subscriptions only Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Remove cleanup to avaid consumers race Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
|
@matzew I'm not sure why do you need a rebase? there's no merge conflict. Or what do you need this PR to be rebased on? |
|
we had updates on how the images are built (see prs on the branch)
Just to be sure there is all fine. Nit exactly sure if that is the reason
of the e2e test failure here
On Mon 29. Mar 2021 at 10:17, Ahmed Abdalla Abdelrehim < ***@***.***> wrote:
@matzew <https://github.com/matzew> I'm not sure why do you need a
rebase? there's no merge conflict. Or what do you need this PR to be
rebased on?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#115 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTVXWSUQXQSHWXUYIG3TGBAR5ANCNFSM4ZZDCTRQ>
.
--
Sent from Gmail Mobile
|
devguyio
force-pushed
the
backport_433_0.21
branch
from
5298749
to
f227427
Compare
|
It fails at this step complaining about that the repo signature couldn't be verified |
|
As said, let's see if a rebase helps regarding images etc etc ... |
|
@matzew it doesn't help, this error is after rebase. I pushed a rebase already |
|
/retest |
|
another error here |
|
@lberk any idea why those two errors above are happening? |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: devguyio, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of (#433) (#481)