Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused workflows #246

Conversation

matzew
Copy link
Member

@matzew matzew commented Jun 22, 2021

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

as per title (they are not used anyways)

/cc @aliok
(Perhaps the script that creates the release branch can do this)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@openshift-ci openshift-ci bot requested a review from aliok June 22, 2021 07:22
@aliok
Copy link

aliok commented Jun 22, 2021

/lgtm
/approve

(Perhaps the script that creates the release branch can do this)
Which script is that? I can do the change there

@openshift-ci
Copy link

openshift-ci bot commented Jun 22, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aliok, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew
Copy link
Member Author

matzew commented Jun 22, 2021

@openshift-merge-robot openshift-merge-robot merged commit 4bdfdd5 into openshift-knative:release-v0.23 Jun 22, 2021
ReToCode pushed a commit to ReToCode/eventing-kafka that referenced this pull request Jan 3, 2023
…#246)

* Replace live-server tests with mocks where applicable

* typo

* linter changes

* imports

* Add comments regarding purpose of wrapper functions

* Make the measurement in the stats reporter test more obvious
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants