Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🤖 Triggering CI on branch 'release-next' after synching to upstream/main #341

Closed
wants to merge 1 commit into from

Conversation

alanfx
Copy link
Collaborator

@alanfx alanfx commented Sep 11, 2021

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Sep 11, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alanfx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@devguyio
Copy link

/retest

@matzew
Copy link
Member

matzew commented Sep 13, 2021

When I run the sed to massage the manifests:

+ RELEASE_YAML=openshift/release/knative-eventing-kafka-channel-ci.yaml
+ sed -i -e 's|registry.ci.openshift.org/openshift/knative-.*:knative-eventing-kafka-consolidated-controller||g' openshift/release/knative-eventing-kafka-channel-ci.yaml
+ sed -i -e 's|registry.ci.openshift.org/openshift/knative-.*:knative-eventing-kafka-consolidated-dispatcher||g' openshift/release/knative-eventing-kafka-channel-ci.yaml
+ sed -i -e 's|registry.ci.openshift.org/openshift/knative-.*:knative-eventing-kafka-webhook||g' openshift/release/knative-eventing-kafka-channel-ci.yaml
+ cat openshift/release/knative-eventing-kafka-channel-ci.yaml

I do get this:

diff --git a/openshift/release/knative-eventing-kafka-channel-ci.yaml b/openshift/release/knative-eventing-kafka-channel-ci.yaml
index 04b54568c..94f58946a 100644
--- a/openshift/release/knative-eventing-kafka-channel-ci.yaml
+++ b/openshift/release/knative-eventing-kafka-channel-ci.yaml
@@ -658,7 +658,7 @@ spec:
       serviceAccountName: kafka-ch-controller
       containers:
       - name: controller
-        image: registry.ci.openshift.org/openshift/knative-nightly:knative-eventing-kafka-consolidated-controller
+        image: 
         env:
         - name: CONFIG_LOGGING_NAME
           value: config-logging

which does explain errors like:

Error from server (Invalid): error when creating "STDIN": Deployment.apps "kafka-ch-controller" is invalid: spec.template.spec.containers[0].image: Required value

@mgencur is there something wrong with the IMAGE_FORMAT env var?
https://github.com/openshift-knative/eventing-kafka/blob/main/openshift/e2e-common.sh#L108

@matzew
Copy link
Member

matzew commented Sep 13, 2021

/retest
🙈

@openshift-ci
Copy link

openshift-ci bot commented Sep 17, 2021

@alanfx: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/prow/47-e2e-aws-ocp-47 4416490 link /test 47-e2e-aws-ocp-47
ci/prow/48-e2e-aws-ocp-48 4416490 link /test 48-e2e-aws-ocp-48

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@devguyio
Copy link

/close
not needed, need #346 instead.

@devguyio devguyio closed this Sep 17, 2021
ReToCode pushed a commit to ReToCode/eventing-kafka that referenced this pull request Jan 3, 2023
bumping knative.dev/eventing 1725902...b20c96b:
  > b20c96b sinkbing implement bindable (# 4794)
  > 8d51418 Bump golang linter version and timeout (# 4808)
  > f882ff0 Add availability rate to upgrade test report (# 4555)
  > a6635bb Patch HPA eventing-webhook min replicas (# 4811)
  > d46c1d0 It is already 2021 (# 4809)
  > fb8fbf7 Adding new source conformance testcase for CRD RBAC (# 4787)
bumping knative.dev/pkg 0d31134...ca02ef7:
  > ca02ef7 Genreconciler properly generates reconciler for Resources with Status (# 2004)

Signed-off-by: Knative Automation <automation@knative.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants