[0.25] Make status.address optional in the KafkaChannel CRD #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/retest |
devguyio
force-pushed
the
release-v0.25
branch
2 times, most recently
from
7add101
to
372cf16
Compare
matzew
force-pushed
the
backport_868
branch
from
a69f277
to
6c07e11
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aliok, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
see #355 |
|
/retest |
|
/retest
On Thu 23. Sep 2021 at 20:27, openshift-ci[bot] ***@***.***> wrote:
@matzew <https://github.com/matzew>: The following test *failed*, say
/retest to rerun all failed tests or /retest-required to rerun all
mandatory failed tests:
Test name Commit Details Required Rerun command
ci/prow/47-e2e-aws-ocp-47 6c07e11
<6c07e11>
link
<https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift-knative_eventing-kafka/344/pull-ci-openshift-knative-eventing-kafka-release-v0.25-47-e2e-aws-ocp-47/1441087368516866048>
true /test 47-e2e-aws-ocp-47
Full PR test history
<https://prow.ci.openshift.org/pr-history?org=openshift-knative&repo=eventing-kafka&pr=344>.
Your PR dashboard
<https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:matzew>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#344 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABGPTQQC754HJIL5KWQU4TUDNWRBANCNFSM5ECLI2FA>
.
--
Sent from Gmail Mobile
|
ReToCode
pushed a commit
to ReToCode/eventing-kafka
that referenced
this pull request
Jan 3, 2023
…penshift-knative#344) * Groundwork for dispatcher subscriber status w/ consumers * Add functionality to serve http of subscribers * Drop callback functions * Fix failing unit test, add unsub check for chanref * Rework http handler to be dispatcher local (not kafkasubscription) * Variable typo fix * Fix copyright years * Change header name to constant * Move subscription handler to its own ServeHTTP func * Remove channelRef in KafkaSubscription * Change bad channelref request to http.StatusNotFound * Add namespace to subscriptions http output * Add Unit tests for servehttp & setready * Split uriSplit into channelRefName{,space} vars * Expose dispatcher http-sub-status port in disatcher svc * Add servehttp diagnostic messages * One more uriSplit -> channelRefName variable rename * Change how we write the http response * Add empty SetReady() method to source RA * Fix consumer_handler_test * more linting * Add back ObserveKind until controller implements substatus scraper * Add more ServeHTTP unit tests * slightly alter where we mark a handler as ready or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of upstream knative-sandbox#868 to our fork
/assign @aliok