🤖 Triggering CI on branch 'release-next' after synching to upstream/main #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: alanfx The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
OCF Webhook is merging this PR |
ReToCode
pushed a commit
to ReToCode/eventing-kafka
that referenced
this pull request
Jan 3, 2023
…ive#423) * Rename some import aliases before creating another common pkg * Move some structs to common package * Fix build * Add missing license header * Move kafka-config map watcher to common pkg * Move code from channel/distr/common/testing to /common/testing * Move more from channel/distr/common/testing to /common/testing * Rename InitializeConfigWatcher->InitializeKafkaConfigMapWatcher * Use common method to watch config-kafka in consolidated contrlr * Use the already existing CM watcher, or create it otherwise * Use the already existing CM watcher, or create it otherwise * Don't start the cm watcher again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.