Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-v1.0] Remove distributed channel docker files #450

Merged
merged 2 commits into from
Nov 19, 2021
Merged

[release-v1.0] Remove distributed channel docker files #450

merged 2 commits into from
Nov 19, 2021

Conversation

devguyio
Copy link

As per title, this is a continuation of #449

@devguyio
Remove distributed channel docker files
a971e0f 
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@openshift-ci openshift-ci bot requested review from aliok and matzew November 18, 2021 22:54
@matzew
Copy link
Member

matzew commented Nov 19, 2021

OK, to do this - should we also remove the generation ?
https://github.com/devguyio/eventing-kafka/blob/release-v1.0/openshift/release/knative-eventing-kafka-distributed-channel-ci.yaml

I was just removing it for main / release-next, but we can do it for 1.0 brnahc too

@devguyio
remove distributed channel ci yaml
ec70841 
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@devguyio
Copy link
Author

OK, to do this - should we also remove the generation ? https://github.com/devguyio/eventing-kafka/blob/release-v1.0/openshift/release/knative-eventing-kafka-distributed-channel-ci.yaml

I was just removing it for main / release-next, but we can do it for 1.0 brnahc too

yep, good catch! done.

matzew
matzew approved these changes Nov 19, 2021
View reviewed changes
Copy link
Member

@matzew matzew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Nov 19, 2021
@openshift-ci
Copy link

openshift-ci bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ca6de93 into openshift-knative:release-v1.0 Nov 19, 2021
ReToCode pushed a commit to ReToCode/eventing-kafka that referenced this pull request Jan 3, 2023
@aliok
Reorganize consolidated dispatcher code, no behavior change (openshif…
5d8683b 
…t-knative#450)

* Reorganize consolidated dispatcher code, no behavior change

* Separate the consolidated dispatcher subscription endpoint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matzew matzew matzew approved these changes

@aliok aliok Awaiting requested review from aliok

Assignees

@matzew matzew

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devguyio @matzew @openshift-merge-robot