Fix rekt compile errors (#1016) #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: serverless-qe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
OCF Webhook is merging this PR |
ReToCode
pushed a commit
to ReToCode/eventing-kafka
that referenced
this pull request
Jan 3, 2023
…le before the subscription is marked ready (openshift-knative#487) * Restart probing dispatchers if the pods change before being ready Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * fix when to return subscribers reconciled Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Proper locking in status prober Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Add a debug log when dispatcher pods change Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Refresh pods probing on dispatcher pod changes Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * change some bad var names Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Add prober test for succeeding only after refreshing pod probing Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Update struct creation after unused field removed Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Reuse same handler for pod informer Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com> * Fix a couple of typos Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
knative-extensions/reconciler-test#261
has breaking changes that this patch fixes.
Signed-off-by: Pierangelo Di Pilato pdipilat@redhat.com