Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.1] Checkout Serverless Operator main branch #509

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #507

/assign pierDipi

The main branch should use the main branch of the SO,
so that we catch problems sooner.

Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 23, 2021
@openshift-ci
Copy link

openshift-ci bot commented Dec 23, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 99578d0 into openshift-knative:release-v1.1 Dec 23, 2021
ReToCode pushed a commit to ReToCode/eventing-kafka that referenced this pull request Jan 3, 2023
* Fix openshift-knative#245

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Removed finalize kind

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* gofmt

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Added a UT

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* WIP

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Rewrote the dispatcher reconciler

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fix err not nil

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Happy linter

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Now it should work

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* This should fix it

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* UT fix

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fixed little mistake

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Fixed another little mistake

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Better code

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Reverted e2e-common.sh

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Bad comment

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Simpler name

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>

* Typo

Signed-off-by: Francesco Guardiani <francescoguard@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants