Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] Install eventing from midstream or from serverless operator #524

Closed

Conversation

devguyio
Copy link

Testing the changes
/hold

@openshift-ci
Copy link

openshift-ci bot commented Jan 26, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from lberk and matzew January 26, 2022 03:49
@devguyio devguyio force-pushed the change-eventing-deps branch 4 times, most recently from 7d33341 to 5dbedf9 Compare January 26, 2022 09:27
Signed-off-by: Ahmed Abdalla <aabdelre@redhat.com>
@matzew
Copy link
Member

matzew commented Jan 26, 2022

I see this passes, but since it's for release next, let's just close this when #528 is in

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2022

@devguyio: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@devguyio
Copy link
Author

/close

@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2022

@devguyio: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Jan 28, 2022
ReToCode pushed a commit to ReToCode/eventing-kafka that referenced this pull request Jan 3, 2023
* Run KafkaSource smokes in upgrade test

* Fixing unit tests

* Restore upgrade tests tags

* Fix codegen

* Reformat README.md

* Golangci Link fix

* Simplify godoc SourceTestScope

Co-authored-by: Martin Gencur <mgencur@redhat.com>

Co-authored-by: Martin Gencur <mgencur@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants