Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop self invoke contained code #589

Merged

Conversation

matzew
Copy link
Member

@matzew matzew commented Feb 24, 2022

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@devguyio
Copy link

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Feb 24, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: devguyio, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew matzew changed the title WIP: Stop self invoke contained code Stop self invoke contained code Feb 24, 2022
@matzew
Copy link
Member Author

matzew commented Feb 24, 2022

/retest

@openshift-merge-robot openshift-merge-robot merged commit 0e85783 into openshift-knative:release-v1.1 Feb 25, 2022
@matzew
Copy link
Member Author

matzew commented Feb 25, 2022

/cherry-pick release-v1.2

@matzew
Copy link
Member Author

matzew commented Feb 25, 2022

/cherry-pick main

@openshift-cherrypick-robot

@matzew: new pull request created: #591

In response to this:

/cherry-pick release-v1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@matzew: new pull request created: #592

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierDipi
Copy link
Member

pierDipi commented Feb 25, 2022

/cherry-pick release-v1.1 (already done)

@openshift-cherrypick-robot

@pierDipi: base branch (release-v1.1) needs to differ from target branch (release-v1.1)

In response to this:

/cherry-pick release-v1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ReToCode pushed a commit to ReToCode/eventing-kafka that referenced this pull request Jan 3, 2023
* API Definition

* Generated Client/Informers/Listers/etc

* goimports whitespace

* Add register test for coverage

* Apply suggestions from code review

* Enhance validation to prohibit future offset times.

* PR feedback...

* rename offset type in spec, add utility fn for sarama millis

* goimports and update-codegen

* Move Status.Annotations to Status, remove OffsetsCalculated State.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants