[release-v1.2] [release-v1.0] Resolve deadLetterSink uri and set it in the KafkaChannel status (#1122) #603
Conversation
…tive-extensions#1122) The subscription reconciler requires that the resolved deadLetterSink, if specified, is set in the status. Signed-off-by: Pierangelo Di Pilato <pdipilat@redhat.com>
|
/test 49-so-forward-compatibility-ocp-49 |
|
@openshift-cherrypick-robot: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…knative#603) * First attempt (unit tests working) * remove accidental changes * remove inadvertent changes * Changing secret name/namespace wasn't being propagated to existing reconciler * Make receiver deployment/service name a constant * Added explicit test for updateKafkaConfig as error-handling is pesky * Simplify secret loading in NewController * Comments and typos * Readme updates * Linter errors * gofmt * dummy * deps * extra files * Changes from PR review * Changed from PR review * whitespace
This is an automated cherry-pick of #601
/assign pierDipi