Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v1.1] Adding dry-run to tweak secret creation, if already present #673

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

matzew
Copy link
Member

@matzew matzew commented Dec 23, 2022

Signed-off-by: Matthias Wessendorf mwessend@redhat.com

Avoid test failure if the secrets in question are already present (similar to strimzi.bash on the Serverless Operator)

Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
@ReToCode
Copy link
Member

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Dec 23, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matzew, ReToCode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@matzew matzew merged commit 81b8c0c into openshift-knative:release-v1.1 Dec 23, 2022
@matzew
Copy link
Member Author

matzew commented Dec 23, 2022

images built... merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants