Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the helloworld go image to MA image. #295

Closed
wants to merge 1 commit into from
Closed

Update the helloworld go image to MA image. #295

wants to merge 1 commit into from

Conversation

AlstonDias
Copy link

No description provided.

@openshift-ci
Copy link

openshift-ci bot commented Aug 8, 2023

Hi @AlstonDias. Thanks for your PR.

I'm waiting for a openshift-knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mgencur
Copy link

mgencur commented Aug 9, 2023

/ok-to-test

@mgencur
Copy link

mgencur commented Aug 9, 2023

Why is this sent only against release-1.8 and not to newer branches?

Copy link
Member

@cardil cardil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@cardil
Copy link
Member

cardil commented Aug 17, 2023

/approve cancel

This should be filled against the upstream.

@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AlstonDias
Once this PR has been reviewed and has the lgtm label, please assign alanfx for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mgencur
Copy link

mgencur commented Aug 17, 2023

We filed this against upstream: knative-extensions#304
The upstream doesn't have a multiarch-image available out of the box so the fix is more complicated.
We could have at least this temporary fix in midstream until the proper fix is upstream.

@cardil
Copy link
Member

cardil commented Oct 16, 2023

I created knative/docs#5718

@cardil
Copy link
Member

cardil commented Oct 16, 2023

/test e2e-aws-ocp-411

@openshift-ci
Copy link

openshift-ci bot commented Oct 16, 2023

@AlstonDias: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ocp-411 0b66f74 link true /test e2e-aws-ocp-411

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@AlstonDias AlstonDias closed this by deleting the head repository Oct 20, 2023
openshift-cherrypick-robot pushed a commit to openshift-cherrypick-robot/kn-plugin-event that referenced this pull request May 7, 2024
Signed-off-by: Knative Automation <automation@knative.team>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants