Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code samples should support s390x and ppc64le archs #5718

Closed
cardil opened this issue Oct 16, 2023 · 3 comments · Fixed by #5753
Closed

Code samples should support s390x and ppc64le archs #5718

cardil opened this issue Oct 16, 2023 · 3 comments · Fixed by #5753
Labels
kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@cardil
Copy link
Contributor

cardil commented Oct 16, 2023

- name: Build helloworld-go image
uses: docker/build-push-action@v4
with:
push: true
platforms: linux/amd64,linux/arm64
context: ./code-samples/serving/hello-world/helloworld-go
tags: ghcr.io/knative/helloworld-go:latest
- name: Build autoscale-go image
uses: docker/build-push-action@v4
with:
push: true
platforms: linux/amd64,linux/arm64
context: ./docs/serving/autoscaling/autoscale-go
tags: ghcr.io/knative/autoscale-go:latest

As the code samples are used in our tests, they should support the same range or architectures as we do the tests with. We should add support for s390x and ppc64le archs.

/kind feature

@knative-prow
Copy link

knative-prow bot commented Oct 16, 2023

@cardil: The label(s) kind/feature cannot be applied, because the repository doesn't have them.

In response to this:

- name: Build helloworld-go image
uses: docker/build-push-action@v4
with:
push: true
platforms: linux/amd64,linux/arm64
context: ./code-samples/serving/hello-world/helloworld-go
tags: ghcr.io/knative/helloworld-go:latest
- name: Build autoscale-go image
uses: docker/build-push-action@v4
with:
push: true
platforms: linux/amd64,linux/arm64
context: ./docs/serving/autoscaling/autoscale-go
tags: ghcr.io/knative/autoscale-go:latest

As the code samples are used in our tests, they should support the same range or architectures as we do the tests with. We should add support for s390x and ppc64le archs.

/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cardil
Copy link
Contributor Author

cardil commented Oct 16, 2023

/kind enhancement

Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant