Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support s390x and ppc64le archs #5753

Merged
merged 1 commit into from
Feb 16, 2024
Merged

Add support s390x and ppc64le archs #5753

merged 1 commit into from
Feb 16, 2024

Conversation

lysliu
Copy link
Contributor

@lysliu lysliu commented Nov 9, 2023

"Fixes #5718 " or "Add support s390x and ppc64le archs"

Proposed Changes

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Nov 9, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: lysliu / name: Yan Song Liu (3020cd5)

@netlify Netlify
Copy link

netlify bot commented Nov 9, 2023 •
edited
Loading

✅ Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3020cd5
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/654c2442c745dc00087dda97
😎 Deploy Preview https://deploy-preview-5753--knative.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@knative-prow Knative Prow
Copy link

knative-prow bot commented Nov 9, 2023

Welcome @lysliu! It looks like this is your first PR to knative/docs 🎉

@knative-prow knative-prow bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 9, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 7, 2024

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 7, 2024
@dprotaso
Copy link
Member

dprotaso commented Feb 8, 2024 •
edited
Loading

/hold

Currently our OSS releases don't work on these architectures

See the following discussion: knative/infra#344

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 8, 2024
@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 9, 2024
@dprotaso
Copy link
Member

/hold cancel
/lgtm
/approve

@knative-prow knative-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 16, 2024
@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Feb 16, 2024
@knative-prow Knative Prow
Copy link

knative-prow bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso, lysliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 16, 2024
@knative-prow knative-prow bot merged commit b9cf0f6 into knative:main Feb 16, 2024
19 checks passed
prushh pushed a commit to prushh/docs that referenced this pull request Apr 30, 2024
@lysliu @prushh
Add support s390x and ppc64le archs (knative#5753)
eece1bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr Awaiting requested review from csantanapr

@nak3 nak3 Awaiting requested review from nak3

Assignees

@dprotaso dprotaso

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code samples should support s390x and ppc64le archs
2 participants
@lysliu @dprotaso