[serverless-1.29.0] patch func deploy task for serverless 1.29.1 #617
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## serverless-1.29.0 #617 +/- ##
====================================================
Coverage ? 63.33%
====================================================
Files ? 94
Lines ? 12670
Branches ? 0
====================================================
Hits ? 8024
Misses ? 3981
Partials ? 665
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
/approve |
|
hello @matejvasek @dsimansk , can we override failed tests on this one and get this merged? |
|
/override "On Cluster RT Test (1.20.x, ubuntu-latest)" |
|
@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override "On Cluster RT Test (1.20.x, ubuntu-latest)" |
|
@matejvasek: Overrode contexts on behalf of matejvasek: On Cluster RT Test (1.20.x, ubuntu-latest), On Cluster Test (1.20.x, ubuntu-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
Test here are failing because of Go version. |
|
On 1.20.5 more test would pass. |
|
/override "E2E Test (1.20.x, ubuntu-latest)" |
|
@matejvasek: Overrode contexts on behalf of matejvasek: E2E Test (1.20.x, ubuntu-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgmt |
|
/override "On Cluster RT Test (1.20.5, ubuntu-latest)" |
|
@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jrangelramos, matejvasek The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override "On Cluster RT Test (1.20.5, ubuntu-latest)" |
|
@matejvasek: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override "On Cluster RT Test (1.20.2, ubuntu-latest)" |
|
@matejvasek: Overrode contexts on behalf of matejvasek: On Cluster RT Test (1.20.2, ubuntu-latest), On Cluster Test (1.20.2, ubuntu-latest) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-merge-robot
merged commit a8f2dd6
into
openshift-knative:serverless-1.29.0
patch for func-deploy task to use midstream specific client built for 1.29.1