Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RELEASE-1.4] Use internal-encryption to deploy internal certificates automatically #23

Merged
merged 2 commits into from
Aug 1, 2022

Conversation

nak3
Copy link

@nak3 nak3 commented Jun 16, 2022

This patch cherr-pick the upstream commit knative-extensions@b9b1e8b.

@openshift-ci openshift-ci bot requested review from alanfx and skonto June 16, 2022 06:59
@codecov-commenter
Copy link

Codecov Report

Merging #23 (3b4778e) into release-1.4 (08c9529) will decrease coverage by 0.43%.
The diff coverage is 62.50%.

@@               Coverage Diff               @@
##           release-1.4      #23      +/-   ##
===============================================
- Coverage        81.83%   81.39%   -0.44%     
===============================================
  Files               18       18              
  Lines             1167     1172       +5     
===============================================
- Hits               955      954       -1     
- Misses             168      174       +6     
  Partials            44       44              
Impacted Files Coverage Δ
pkg/config/config.go 0.00% <0.00%> (ø)
pkg/generator/ingress_translator.go 85.55% <100.00%> (ø)
pkg/reconciler/ingress/config/store.go 91.66% <100.00%> (-0.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 08c9529...3b4778e. Read the comment docs.

@nak3
Copy link
Author

nak3 commented Jul 28, 2022

@skonto Hmm... I pinned knative.dev/hack and knative.dev/pkg in go.mod:

replace (
	knative.dev/hack => knative.dev/hack v0.0.0-20220411131823-6ffd8417de7c
	knative.dev/pkg => knative.dev/pkg v0.0.0-20220412134708-e325df66cb51
)

so I think it makes the difference between upstream and downstream. Without these pinning, knative.dev/pkg will be bumped to v1.6's knative.dev/pkg which is not expected.

@skonto
Copy link

skonto commented Jul 29, 2022

/lgtm

@openshift-ci
Copy link

openshift-ci bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nak3, skonto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@skonto
Copy link

skonto commented Aug 1, 2022

@nak3 feel free to merge manually.

@nak3 nak3 merged commit 942ae46 into openshift-knative:release-1.4 Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants