Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tests also validate batch jobs #2801

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Aug 1, 2024

Related to https://issues.redhat.com/browse/SRVCOM-3203

Proposed Changes

@openshift-ci openshift-ci bot requested review from pierDipi and skonto August 1, 2024 06:41
@openshift-ci openshift-ci bot added the approved label Aug 1, 2024
Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@mgencur
Copy link
Contributor Author

mgencur commented Aug 1, 2024

/cherry-pick release-1.32
/cherry-pick main

@openshift-cherrypick-robot
Copy link
Contributor

@mgencur: once the present PR merges, I will cherry-pick it on top of release-1.32 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.32
/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ea45ecd and 2 for PR HEAD dcb6674 in total

@openshift-ci openshift-ci bot removed the lgtm label Aug 1, 2024
@pierDipi
Copy link
Member

pierDipi commented Aug 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Aug 1, 2024
Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mgencur, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD ea45ecd and 2 for PR HEAD 6034cd2 in total

Copy link
Contributor

openshift-ci bot commented Aug 1, 2024

@mgencur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/415-test-upgrade-aws-415 6034cd2 link true /test 415-test-upgrade-aws-415

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mgencur
Copy link
Contributor Author

mgencur commented Aug 1, 2024

As can be seen from the failed run:
The post-install jobs for 1.33.2 don't have the ttlSecondsAfterFinished element but the post-install jobs from the original version 1.33.0 (before upgrade) are still there and the check fails for them.
The existing test is probably enough. I'm closing this PR.

@mgencur mgencur closed this Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants