Update upgrade test image template to use Konflux images #2908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using image mirrored, we will start using images built with Konflux, this will further help testing on different arch once we have multi-arch builds. Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
Skipping CI for Draft Pull Request. |
|
/test 416-test-upgrade-aws-416 |
mgencur
reviewed
Oct 2, 2024
|
|
||
| # Mapping based on https://github.com/openshift/release/tree/master/core-services/image-mirroring/knative | ||
| # for non-REKT tests. | ||
| base="quay.io/openshift-knative/" |
There was a problem hiding this comment.
The images you're replacing here must be multi-arch as they're used on P/Z and arm now.
See e.g. https://quay.io/repository/openshift-knative/eventing/eventshub?tab=tags&tag=latest - it's multiarch.
There was a problem hiding this comment.
@rudyredhat1 what's the status of multi arch builds feature in hack?
There was a problem hiding this comment.
sorry missed this notification, checked now, I think it will take time, trying to understand how the kustomize patches can be used for the docket-build-oci-ta.yaml , i will check this weekend and will try to update something on this MR - openshift-knative/hack#316 , cc @pierDipi
|
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
/test 416-test-upgrade-aws-416 |
|
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
…thub.com:pierDipi/serverless-operator into replace-upgrade-test-image-template-with-konflux
|
/test 416-test-upgrade-aws-416 |
pierDipi
changed the title
|
pierDipi
commented
Oct 11, 2024
pierDipi
commented
Oct 11, 2024
|
/test 416-test-upgrade-aws-416 |
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
pierDipi
force-pushed
the
replace-upgrade-test-image-template-with-konflux
branch
from
a386d93
to
ce30904
Compare
pierDipi
changed the title
mgencur
reviewed
Oct 11, 2024
test/lib.bash
Outdated
|
|
||
| default_knative_eventing_images | ||
| default_knative_eventing_kafka_broker_images | ||
| default_knative_serving_images | ||
|
|
||
| # Mapping based on https://github.com/openshift/release/tree/master/core-services/image-mirroring/knative |
There was a problem hiding this comment.
This comment is out-of-date now. Otherwise this looks good to me now (as long as we get multiarch images later:))
There was a problem hiding this comment.
Multi arch builds are already been built 🎉
There was a problem hiding this comment.
Hmm. Which image are multiarch? trying e.g. this and it's "manifest", not "manifest list"
ᐅ skopeo inspect --raw docker://quay.io/redhat-user-workloads/ocp-serverless-tenant/serverless-operator-135/kn-serving-autoscaler:latest
{"schemaVersion":2,"mediaType":"application/vnd.oci.image.manifest.v1+json","config":{"mediaType":"application/vnd.oci.image.config.v1+json","digest":"sha256:90744c7fe55c3b5893b4aff7098dd1392ec60c480a916a37d519ddf8d1cb8e98","size":7755},"layers":[{"mediaType":"application/vnd.oci.image.layer.v1.tar+gzip","digest":"sha256:133388727492505cb9d292d14f00942ad2915ab7df3ec1aabbea88cd25035f7b","size":39460227},{"mediaType":"application/vnd.oci.image.layer.v1.tar+gzip","digest":"sha256:ad929d8e8e974c0686ebc2b5a27fa5ddf62125bc5e19f0cc40a5c1dbd0e9ba47","size":28703160},{"mediaType":"application/vnd.oci.image.layer.v1.tar+gzip","digest":"sha256:7431e963fae10aee616b28966de17f86660d5943dc560bea73e4c077f6997609","size":36262}],"annotations":{"org.opencontainers.image.base.digest":"sha256:d531ff26bffe832391600e8137f01b9d09a712c721ebe966b98d647bd91bc261","org.opencontainers.image.base.name":"registry.access.redhat.com/ubi8/ubi-minimal:latest"}}
There was a problem hiding this comment.
Or you mean, somebody is already working on that but not fully done yet.
There was a problem hiding this comment.
Serving needs to merge their PR: openshift-knative/serving#912
Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
|
@pierDipi Yes. The test is trying to pull |
mgencur
reviewed
Oct 14, 2024
Co-authored-by: Martin Gencur <mgencur@redhat.com>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 9a59043
into
openshift-knative:main
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using image mirrored, we will start using images built with Konflux, this will further help testing on different arch once we have multi-arch builds while also consolidating the images we use for building and testing