-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support console unmanaged mode #2950
Support console unmanaged mode #2950
Conversation
0d9ff6e
to
24a423b
Compare
Should we cherry-pick for 1.34 as it supports 1.34? 🤔 |
24a423b
to
6165bc0
Compare
I think we can and release it in the future |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierDipi, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.34 |
@pierDipi: once the present PR merges, I will cherry-pick it on top of release-1.34 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
ACK it makes sense to work with Unmanaged state. |
LGTM, feel free to unhold |
/retest |
/unhold |
/override ? |
@skonto: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/override "Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_console_status_predicate" |
@skonto: Overrode contexts on behalf of skonto: Red Hat Konflux / serverless-operator-135-enterprise-contract / pr group fix_console_status_predicate, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-ingress-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-kn-operator-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-metadata-webhook-135, Red Hat Konflux / serverless-operator-135-enterprise-contract / serverless-openshift-kn-operator-135 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test 416-test-upgrade-aws-416 |
42269fa
into
openshift-knative:main
@pierDipi: new pull request created: #2956 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Fixes JIRA #
Proposed Changes
We currently expect this to be true.