Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct FBC image when installing catalog source #2953

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Use correct FBC image when installing catalog source #2953

merged 7 commits into from
Oct 21, 2024

Conversation

mgencur
Copy link
Contributor

@mgencur mgencur commented Oct 17, 2024 •
edited
Loading

Proposed Changes

  • Include specific bundle in the catalog only if the respective entry was added in the channel. If the entry is already there it means the bundle was already added.
  • The regenerated catalog now includes version 1.34 that comes from registry.redhat.io as the release is already out and baked in the production catalog. This replaces the previous entry that was coming from CI registry.

@mgencur mgencur mentioned this pull request Oct 17, 2024
Merged
@mgencur mgencur mentioned this pull request Oct 18, 2024
Merged
creydr
creydr reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@creydr creydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Oct 21, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, mgencur

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pierDipi pierDipi merged commit 945efdf into openshift-knative:main Oct 21, 2024
20 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@creydr creydr creydr left review comments

@dsimansk dsimansk Awaiting requested review from dsimansk

Assignees

@creydr creydr

Labels
approved lgtm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mgencur @creydr @pierDipi