IBU pre/post upgrade CSVs and seed node name validation #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcornea
force-pushed
the
ibu_validation_csv
branch
from
6afdc7a to
8d8974f
Compare
mcornea
changed the title
yprokule
reviewed
Feb 2, 2024
| var installedCSV []string | ||
|
|
||
| for _, csv := range csvList { | ||
| installedCSV = append(installedCSV, csv.Object.Name) |
There was a problem hiding this comment.
duplicated entries would end up here from operators that are installed in all the namespaces(or ListClusterServiceVersionInAllNamespaces provides already filtered list or it's OK to have duplicated entries?)
There was a problem hiding this comment.
Currently there are no cluster wide operators installed on these nodes but I updated it so that it adds an operator to the list only if it's not there.
mcornea
force-pushed
the
ibu_validation_csv
branch
from
8d8974f to
2c7bf5c
Compare
mcornea
changed the title
mcornea
force-pushed
the
ibu_validation_csv
branch
from
2c7bf5c to
62b166a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends-On: openshift-kni/eco-goinfra#238