Skip to content
This repository has been archived by the owner on Jul 23, 2019. It is now read-only.

Consider dropping deploy kernel/ramdisk from install config #58

Closed
russellb opened this issue Apr 24, 2019 · 11 comments
Closed

Consider dropping deploy kernel/ramdisk from install config #58

russellb opened this issue Apr 24, 2019 · 11 comments

Comments

@russellb
Copy link
Member

The install config currently includes options like:

          deploy_kernel:  "http://172.22.0.1/images/ironic-python-agent.kernel"
          deploy_ramdisk: "http://172.22.0.1/images/ironic-python-agent.initramfs"

We should aim for Ironic to be an implementation detail, and this leaks a bit of info. We also don't expect this image to ever change. Since we know exactly what image should be used, the installer should automatically download it and ensure it's available via HTTP from somewhere.

@stbenjam
Copy link
Member

Should the installer do it? Or could we have the Ironic container take care of it? If the installer needs to do it, where do we host it? We'd have to have it available from somewhere in the bootstrap environment, and also later in the running cluster.

@russellb
Copy link
Member Author

Yeah, that's a good idea. Maybe we could include it in our ironic container?

I'm not tied to any particular solution. I just think making this not a concern of the install-config should be a todo item.

@dhellmann
Copy link
Member

When we talked about this in the context of packaging the operator and actuator, we tossed around the idea of having the operator provide a web server container with these things and the actuator providing a web server containing the images to be deployed. @imain was looking at that.

@russellb
Copy link
Member Author

That works for day 2, but not the day 1 installer when the operator and actuator aren't running yet.

@dhellmann
Copy link
Member

Good point. We also talked about that container just being a cache, so maybe we can use the same container image in both cases?

@hardys
Copy link

hardys commented Jun 13, 2019

I think with the new downloader containers, and the work to move those and the ironic services to the bootstrap VM, we can make progress on this soon.

Ref #100 - the IP of the bootstrap VM will be known (either hardcoded or available via a survey input), so we will know where the ramdisk/kernel and RHCOS image should be when deploying via terraform (the same approach can be used on cluster too, but the URL will obviously be different).

One question is what do we put in the baremetal host definition for the masters, when the URL for the images goes away as soon as bootstrap is completed?

@dhellmann
Copy link
Member

One question is what do we put in the baremetal host definition for the masters, when the URL for the images goes away as soon as bootstrap is completed?

The master hosts will be registered with a machine reference but no image information. That will make them appear as "externally provisioned" and prevent the operator from trying to re-provision them when it is launched inside the cluster.

@hardys
Copy link

hardys commented Jun 14, 2019

One question is what do we put in the baremetal host definition for the masters, when the URL for the images goes away as soon as bootstrap is completed?

The master hosts will be registered with a machine reference but no image information. That will make them appear as "externally provisioned" and prevent the operator from trying to re-provision them when it is launched inside the cluster.

Ah thanks, I'd forgotten the externally provisioned status omitted the image details. Sounds like we can just remove this from the install-config when the images are hosted on the bootstrap VM then.

@russellb
Copy link
Member Author

@hardys It looks like the change to make Ironic run on the bootstrap VM will remove the need for these install-config options. Can you confirm? Do you want to include dropping these options in your PR, or should I file an openshift/installer issue to remind us to follow up on it?

@hardys
Copy link

hardys commented Jul 22, 2019

@hardys It looks like the change to make Ironic run on the bootstrap VM will remove the need for these install-config options. Can you confirm? Do you want to include dropping these options in your PR, or should I file an openshift/installer issue to remind us to follow up on it?

Yes my plan is to drop all image install-config options through a combination of openshift/installer#2037 to decouple the images internally, then the boostrap-ironic change which will mean we know where the images will reside in the master deployment case.

I think we do need to copy #68 to openshift/installer though?

@hardys
Copy link

hardys commented Jul 22, 2019

openshift/installer#2060 raised to move tracking of #68 to openshift/install

@hardys hardys closed this as completed Jul 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants